Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Consent Support to Doubleclick Kit #44

Merged
merged 2 commits into from
Mar 5, 2024
Merged

feat: Add Consent Support to Doubleclick Kit #44

merged 2 commits into from
Mar 5, 2024

Conversation

alexs-mparticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Adds a check to initForwarder and processEvents so that if the consent state changes, we alert Google via their gtag as per their Consent Mode Documention

Testing Plan

  • Was this tested locally? If not, explain why.
  • Set up Consent Mapping and Privacy Configuration via the mParticle UI
  • Using our [Data Privacy Controls] instructions, toggle some of the mapped consent states via the developer console
  • Verify that mapped events appear in window.dataLayer via browser developer console as updates with updated values

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

rmi22186
rmi22186 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I compared this against the changes in https://github.com/mparticle-integrations/mparticle-javascript-integration-google-analytics-4/pull/56/files and looks good!

@alexs-mparticle alexs-mparticle merged commit 377a2ad into development Mar 5, 2024
2 checks passed
alexs-mparticle added a commit that referenced this pull request Mar 5, 2024
@alexs-mparticle
feat: Add Consent Support to Doubleclick Kit (#44)
488ac47
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
@mparticle-automation
chore(release): 2.1.0 [skip ci]
f1a64c9 
# [2.1.0](v2.0.4...v2.1.0) (2024-3-5)

### Features

* Add Consent Support to Doubleclick Kit ([#44](#44)) ([488ac47](488ac47))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexs-mparticle @rmi22186