Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send default and update consent payloads on kit init #48

Conversation

mmustafa-tse
Copy link
Contributor

Summary

  • Same summary as this PR we had for the GTM kit

Testing Plan

  • [Y] Was this tested locally? If not, explain why.
  • Tested E2E locally with overrides as well as unit tested

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

common.consentMappings
);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/tests.js Outdated
window.dataLayer[5][0].should.equal('consent');
window.dataLayer[5][1].should.equal('update');
window.dataLayer[5][2].should.deepEqual(expectedDataLayerFinal[2]);
// Consent Update is index 5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what even is index 4?

@rmi22186 rmi22186 merged commit 0cd8f36 into mparticle-integrations:development Oct 8, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 9, 2024
## [2.1.3](v2.1.2...v2.1.3) (2024-10-09)

### Bug Fixes

* send default and update consent payloads on kit init ([#48](#48)) ([0cd8f36](0cd8f36))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 2.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants