-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: send default and update consent payloads on kit init #48
Merged
rmi22186
merged 2 commits into
mparticle-integrations:development
from
mmustafa-tse:fix/conesnt_default_update
Oct 8, 2024
Merged
fix: send default and update consent payloads on kit init #48
rmi22186
merged 2 commits into
mparticle-integrations:development
from
mmustafa-tse:fix/conesnt_default_update
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmi22186
reviewed
Oct 8, 2024
common.consentMappings | ||
); | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rmi22186
reviewed
Oct 8, 2024
test/tests.js
Outdated
window.dataLayer[5][0].should.equal('consent'); | ||
window.dataLayer[5][1].should.equal('update'); | ||
window.dataLayer[5][2].should.deepEqual(expectedDataLayerFinal[2]); | ||
// Consent Update is index 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what even is index 4?
rmi22186
approved these changes
Oct 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
## [2.1.3](v2.1.2...v2.1.3) (2024-10-09) ### Bug Fixes * send default and update consent payloads on kit init ([#48](#48)) ([0cd8f36](0cd8f36))
🎉 This PR is included in version 2.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)