Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inclusion as Android app module #195

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

gxcare
Copy link

@gxcare gxcare commented Jul 22, 2022

With those two files the library can be used as a module in Android apps.

The only requirement for the user is to add the following declaration in the app build.gradle file:
ext { compileSdkVersion = 31 }

Copy link

@Angor313 Angor313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/main/AndroidManifest.xml

@sphrak
Copy link

sphrak commented Jan 12, 2023

correct me if im wrong but wont this make it impossible for jvm only projects to use it since it always applies the android framework plugin? 🤔

@gxcare
Copy link
Author

gxcare commented Jan 12, 2023

Yes, the provided gradle file is able to build only for Android, but you are not providing one for jvm only as I guess in that case the build environment is maven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants