-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve deprecation warnings related to datetime.utcnow in python 3.12 #335
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @brouberol,
Thank you for taking care of that warning!
I'd like to suggest a way to simplify your changes a bit.
Co-authored-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
Thanks @Jamim! Good call indeed |
will this be bundled into release 3.4 or just a minor update? |
Hello @phifuh,
Sorry, but it looks like chances of this happening are near zero. Best regards! |
@Jamim thats fair, eventually someone might fork this project and actively maintain it, at least thats what I hope |
guess it makes more sense to migrate to https://github.com/jpadilla/pyjwt |
When upgrading my project to python 3.12, I started seeing deprecation warnings related to the use of
datetime.datetime.utcnow
.This PR simply implements the suggestion (in a backwards-compatible fashion), to get rid of these warnings in all projects depending on
python-jose
.Regards
Fixes #334