osd/console: default to semitransparent back color #15549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default OSD and subs have no shadow, but if you do set a --osd/sub-shadow-offset, the current default white shadow color looks bad around white text with black border. Default to semitransparent black instead. Use the same color box profiles were using to allow removing it from there.
|
Download the artifacts for this pull request: |
The previous commit changed --osd-back/shadow-color to nearly the same one console was using. This allows unhardcoding it from there and using --osd-back-color even with --osd-border-style=outline-and-shadow for consistency with the rest of the OSD.
guidocella
force-pushed
the
black-back-color
branch
from
85d4372 to
c3c0c0f
Compare
kasper93
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sub/osd: default to a semitransparent black back color
By default OSD and subs have no shadow, but if you do set a --osd/sub-shadow-offset, the current default white shadow color looks bad around white text with black border. Default to semitransparent black instead. Use the same color box profiles were using to allow removing it from there.
console.lua: inherit --osd-back-color
The previous commit changed --osd-back/shadow-color to nearly the same one console was using. This allows unhardcoding it from there and using --osd-back-color even with --osd-border-style=outline-and-shadow for consistency with the rest of the OSD.