💥 preparing framework for multi exchange support (Sourcery refactored) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
sourcery-ai
bot
force-pushed
the
sourcery/dev
branch
15 times, most recently
from
c6e07e9
to
b9721d9
Compare
sourcery-ai
bot
force-pushed
the
sourcery/dev
branch
from
b9721d9
to
288f5cf
Compare
| async def get_quote(cex, symbol): | ||
| async def get_quote(self, symbol): |
There was a problem hiding this comment.
Function CexTrader.get_quote refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name)
Comment on lines
-163
to
+165
| filtered_balance = { | ||
| if filtered_balance := { | ||
| k: v for k, v in raw_balance.items() if v is not None and v > 0 | ||
| } | ||
| if filtered_balance: | ||
| }: |
There was a problem hiding this comment.
Function CexTrader.get_account_balance refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-208
to
+207
| positions = [p for p in positions if p["type"] == "open"] | ||
| if positions: | ||
| if positions := [p for p in positions if p["type"] == "open"]: |
There was a problem hiding this comment.
Function CexTrader.get_account_position refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #37 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
devbranch, then run:Help us improve this pull request!