-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mrc-6097 Metadata endpoint #4
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 98.27% 98.41% +0.13%
==========================================
Files 13 15 +2
Lines 116 126 +10
Branches 15 15
==========================================
+ Hits 114 124 +10
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!! just a capitalization comment
Co-authored-by: Anmol Thapar <mr.anmolthapar@gmail.com>
This branch implements a basic endpoint to provide metadata about the discovered datasets. For the test datasets the data part of the response looks like:
We currently only support one dataset type, "tile", with the idea that other datasets may be supported later.
When this happens we might change the metadata format somewhat, e.g. maybe a dataset supports multiple types of data, with shared feature ids. To be determined...
The static metadata is built on server start-up, from the discovered datasets, in a new
buildMetadata
method.Other changes in this branch:
buildMetadata
, moved to aserver
folder to avoid top level getting too cluttered.server.ts
itself it still at the top level - I'll move that if it's too confusing!integrationTest
:getData
which expects a JSON success response and returnsbody.data
.