calculate_eir function correction #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on't think it needs to be multiplied by psi. When these values are drawn in lines 135-140 of biting_process.R they get multiplied by psi in line 144. That means we're effectively multiplying these values by psi^2. I think we can correct this by adjusting the calculation thusly. The two tests at the end would then need adjusting (one way or another) to reflect this change - which could use improving.
RJSheppard
force-pushed
the
initial_eir_calculation_correction
branch
from
4a1d779 to
b8f3c27
Compare
giovannic
requested changes
May 8, 2024
pwinskill
approved these changes
May 9, 2024
giovannic
approved these changes
May 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function that calculates the initial EIR doesn't appear to be quite right. I don't think it needs to be multiplied by psi. When these values are drawn in lines 135-140 of biting_process.R they get multiplied by psi in line 144. That means we're effectively multiplying these values by psi^2. I think we can correct this by adjusting the calculation thusly.
The two tests at the end would then need adjusting (one way or another) to reflect this change - which could probably use some improving.
I've drawn a couple of plots to show the difference this is trying to correct and that it doesn't change too much:
eir_calculation_comp_timesteps.pdf
eir_calculation_comp.pdf