lm pcr prevalence explicit #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on't think it needs to be multiplied by psi. When these values are drawn in lines 135-140 of biting_process.R they get multiplied by psi in line 144. That means we're effectively multiplying these values by psi^2. I think we can correct this by adjusting the calculation thusly. The two tests at the end would then need adjusting (one way or another) to reflect this change - which could use improving.
… to rendering tests to reflect additional outputs.
RJSheppard
force-pushed
the
lm_pcr_prevalence_explicit
branch
from
827ffd7 to
b9b923c
Compare
…n from another PR.
giovannic
approved these changes
May 8, 2024
There was a problem hiding this comment.
I approve! As long as n_detect_pcr including all of U is something that users would expect. @pwinskill ?
Good question Giovanni! |
|
Just checked with Lucy and she says that's all good! |
pwinskill
approved these changes
May 16, 2024
calculate_eir function correction
dqrng just released a new version, which means we can stop relying on the mrc-ide r-universe as an additional repository.
Depend on dqrng from CRAN again.
… to rendering tests to reflect additional outputs.
…n from another PR.
…de/malariasimulation into lm_pcr_prevalence_explicit
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
malariasimulation currently only outputs lm prevalence, but it may be useful to also output pcr prevalence. I've added this functionality in.