Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple parameters in models from functions #105

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Nov 7, 2024

No description provided.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (aa11bb2) to head (47a929b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          70       70           
  Lines        5450     5453    +3     
=======================================
+ Hits         5433     5436    +3     
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richfitz richfitz requested a review from weshinsley November 7, 2024 16:48
Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One doc fix...

##' @return A [monty_model] object that computes log density with the
##' provided `density` function, given a numeric vector argument
##' representing all parameters.
##' representing all parameters. This is `FALSE` by default because
##' we cannot determine this automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the last sentence should be on the end of @param allow_multiple_parameters

@richfitz richfitz merged commit e939043 into main Nov 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants