Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use R macro #116

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Don't use R macro #116

merged 2 commits into from
Nov 27, 2024

Conversation

richfitz
Copy link
Member

R_FINITE is not available without using R's headers, and should not be used in this context

@richfitz richfitz marked this pull request as ready for review November 27, 2024 14:32
@richfitz richfitz requested a review from weshinsley November 27, 2024 14:32
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (be63264) to head (1ad7e33).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          73       73           
  Lines        5582     5582           
=======================================
  Hits         5558     5558           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weshinsley weshinsley merged commit 9281209 into main Nov 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants