Add spinner to progress bar #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 66 66
Lines 5226 5229 +3
=======================================
+ Hits 5215 5218 +3
Misses 11 11 ☔ View full report in Codecov by Sentry. |
weshinsley
approved these changes
Dec 13, 2024
| monty_spinner <- function(date = Sys.Date()) { | ||
| getOption( | ||
| "cli.spinner", | ||
| if (format(date, "%m") == "12") "christmas" else "dots12") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When things don't change that often it looks like things have stalled, a progress bar helps with that. This PR uses the cli progress bar to add a simple spinner at the start of the progress; I think we had this in mcstate?