Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start on migration vignette #131

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Start on migration vignette #131

merged 4 commits into from
Dec 16, 2024

Conversation

richfitz
Copy link
Member

In the effort that the perfect not be the enemy of the good, here's a start on this, we can add more later.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (1917a4a) to head (fc2b4f4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          66       66           
  Lines        5232     5232           
=======================================
  Hits         5221     5221           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richfitz richfitz marked this pull request as ready for review December 13, 2024 17:33
@richfitz richfitz requested a review from weshinsley December 13, 2024 17:33
Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - quite typos

vignettes/migration.Rmd Outdated Show resolved Hide resolved
vignettes/migration.Rmd Outdated Show resolved Hide resolved
vignettes/migration.Rmd Outdated Show resolved Hide resolved
@richfitz richfitz merged commit bbe410f into main Dec 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants