Update with 2024 options #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update model options for countries with no 2023 results
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 711 710 -1
=========================================
- Hits 711 710 -1 ☔ View full report in Codecov by Sentry. |
|
Testing with Naomi here mrc-ide/naomi#447 |
r-ash
approved these changes
Nov 15, 2024
jeffeaton
reviewed
Nov 15, 2024
| @@ -1,3 +1,7 @@ | |||
| # naomi.options 1.3.0 | |||
|
|
|||
| * Update default for 2024/2025 HIV estimates | |||
There was a problem hiding this comment.
Can you add to this the details of specific updates that you put in the PR notes? That may be helpful to refer back to next year.
r-ash
reviewed
Nov 18, 2024
| MLI,MLI,1,CY2024Q4,CY2025Q3,CY2013Q1,MLI2012DHS,,,FALSE,,TRUE,TRUE,TRUE,2024,12,,2024,,2024,national,TRUE,250,1000,1000,TRUE,-4,TRUE,1,TRUE,1,TRUE,1,national,sex_age_group,national,sex_age_group,national,sex_age_group,national,sex_age_group,logistic,1,TRUE,TRUE,TRUE,FALSE,FALSE,TRUE,CY2026Q3,CY2027Q3,1 | ||
| MOZ,MOZ,3,CY2024Q4,CY2025Q3,CY2021Q3,MOZ2021PHIA,MOZ2021PHIA,,FALSE,,TRUE,TRUE,TRUE,2024,12,,2024,2021,2024,national,TRUE,250,1000,1000,TRUE,-4,TRUE,1,TRUE,1,TRUE,1,national,sex_age_group,national,sex_age_group,national,sex_age_group,national,sex_age_group,logistic,1,TRUE,TRUE,TRUE,FALSE,TRUE,TRUE,CY2026Q3,CY2027Q3,3 | ||
| MWI,MWI,5,CY2024Q4,CY2025Q3,CY2020Q3,MWI2020PHIA,MWI2020PHIA,,FALSE,,TRUE,TRUE,TRUE,2024,12,2020,2024,2020,2024,national,TRUE,250,1000,1000,TRUE,-4,TRUE,1,TRUE,1,TRUE,1,national,sex_age_group,national,sex_age_group,national,sex_age_group,national,sex_age_group,logistic,1,TRUE,TRUE,TRUE,FALSE,FALSE,TRUE,CY2026Q3,CY2027Q3,3 |
There was a problem hiding this comment.
Should this be 4 for the area level?
Test data is coming through with
- Country - level 0
- Region - level 1
- Zone - level 2
- District - level 3
- District + Metro - level 4
There was a problem hiding this comment.
No, we don't want to do this. The actual Malawi data does have 6 levels. So 5 is right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model options updated:
Calendar quarters T2 - T5 updated to 2024 - 2027
ANC T2 options set to 2025
Calibration method set to logistic
Note: For 2023 CAF, CMR and STP did not submit approved Naomi files. MWI and ZAF used bespoke model options. Default options from prior year were used in these cases.