Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NM-103] Add function to create datapack download standalone #460

Merged
merged 7 commits into from
Dec 10, 2024
Merged

[NM-103] Add function to create datapack download standalone #460

merged 7 commits into from
Dec 10, 2024

Conversation

r-ash
Copy link
Contributor

@r-ash r-ash commented Dec 6, 2024

No description provided.

@r-ash r-ash changed the title Add function to create datapack download standalone [NM-103] Add function to create datapack download standalone Dec 6, 2024
@r-ash r-ash requested review from jeffeaton and rtesra December 6, 2024 11:02
jeffeaton
jeffeaton requested changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@jeffeaton jeffeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion: Make this an Excel download workbook with the data pack CSV on the first sheet, and the metadata discussed on second sheet. (Feel free to split up to more sheets if useful)

What is the filename for the download? Is that specified here or in hintr?

@r-ash
Copy link
Contributor Author

r-ash commented Dec 6, 2024

What is the filename for the download? Is that specified here or in hintr?

That is in hintr. I did mean to ask about that actually but then slipped my mind. At the moment it will be $iso3_datapack_$date.xlsx which fits the general structure of the other files. But let me know if you'd like anything else.

@jeffeaton
Copy link
Collaborator

What is the filename for the download? Is that specified here or in hintr?

That is in hintr. I did mean to ask about that actually but then slipped my mind. At the moment it will be $iso3_datapack_$date.xlsx which fits the general structure of the other files. But let me know if you'd like anything else.

Can we do: $iso3_pepfar-tst-2025_$date-time.xlsx?

Analogous to we do for main output: BWA_naomi-output_20241208-2036.zip

Let's connect tomorrow and see if we can pin down that metadata sheet?

@r-ash r-ash force-pushed the nm-103 branch 2 times, most recently from 1b35d87 to a57c1cd Compare December 10, 2024 15:46
@r-ash r-ash requested a review from jeffeaton December 10, 2024 18:58
@r-ash r-ash merged commit 3f88595 into master Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtesra rtesra rtesra approved these changes

@jeffeaton jeffeaton Awaiting requested review from jeffeaton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-ash @jeffeaton @rtesra