Apply Spectrum ART adjustments #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffeaton
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Hi — thanks for this.
Overall comment here: it looks like the function is returning additional columns with the scalar and absolute adjustment factors. Is that required to return both of those, or would it be sufficient to simply return two columns with the raw and adjusted ART totals?
It also looks to me like there is a discrepancy where in the art_dec31 column might be returning raw numbers for adults and adjusted numbers for children. I might be parsing it wrong though.
r-ash
requested changes
Dec 11, 2024
Comment on lines
+33
to
+34
| # TO DO: Ensure ART adjustments in Spectrum are applied | ||
| # Make a test "pjnz" file |
There was a problem hiding this comment.
This test has been written now right? In test--spectrum.R?
…rc-ide/naomi into Apply-spectrum-ART-adjustments
rtesra
force-pushed
the
Apply-spectrum-ART-adjustments
branch
from
8664535 to
e1de628
Compare
r-ash
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_dp_art_dec31()with new .DP file flags to ensure ART adjustment factor and ART patient reallocation counts are applied to number on ART extracted from Spectrum.