fix unit tests

mrc-ide · Oct 11, 2023 · 61c5081 · 61c5081
1 parent ae6b549
commit 61c5081
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 7 deletions.
diff --git a/app/static/tests/mocks.ts b/app/static/tests/mocks.ts
@@ -189,6 +189,8 @@ export const mockMultiSensitivityState = (state: Partial<MultiSensitivityState>
     };
 };
 
+const mockUserPreferences = () => ({ showUnlabelledSessions: true });
+
 export const mockBasicState = (state: Partial<BasicState> = {}): BasicState => {
     return {
         sessionId: "123",
@@ -215,6 +217,7 @@ export const mockBasicState = (state: Partial<BasicState> = {}): BasicState => {
         configured: false,
         persisted: true,
         language: mockLanguageState(),
+        userPreferences: mockUserPreferences(),
         ...state
     };
 };
@@ -267,6 +270,7 @@ export const mockFitState = (state: Partial<FitState> = {}): FitState => {
         configured: false,
         persisted: false,
         language: mockLanguageState(),
+        userPreferences: mockUserPreferences(),
         ...state
     };
 };
@@ -298,6 +302,7 @@ export const mockStochasticState = (state: Partial<StochasticState> = {}): Stoch
         configured: false,
         persisted: false,
         language: mockLanguageState(),
+        userPreferences: mockUserPreferences(),
         ...state
     };
 };

diff --git a/app/static/tests/unit/localStorageManager.test.ts b/app/static/tests/unit/localStorageManager.test.ts
@@ -1,8 +1,13 @@
 import { localStorageManager } from "../../src/app/localStorageManager";
 
 describe("localStorageManager for sessions", () => {
-    const spyOnGetItem = jest.spyOn(Storage.prototype, "getItem").mockReturnValue("[\"session1\", \"session2\"]");
-    const spyOnSetItem = jest.spyOn(Storage.prototype, "setItem");
+    let spyOnGetItem: any;
+    let spyOnSetItem : any;
+
+    beforeAll(() => {
+        spyOnGetItem = jest.spyOn(Storage.prototype, "getItem").mockReturnValue("[\"session1\", \"session2\"]");
+        spyOnSetItem = jest.spyOn(Storage.prototype, "setItem");
+    });
 
     beforeEach(() => {
         jest.clearAllMocks();
@@ -48,9 +53,14 @@ describe("localStorageManager for sessions", () => {
 });
 
 describe("localStorageManager gets and saves user preferences", () => {
-    const spyOnGetItem = jest.spyOn(Storage.prototype, "getItem")
-        .mockReturnValue("{\"showUnlabelledSessions\": false}");
-    const spyOnSetItem = jest.spyOn(Storage.prototype, "setItem");
+    let spyOnGetItem: any;
+    let spyOnSetItem: any;
+
+    beforeAll(() => {
+        spyOnGetItem = jest.spyOn(Storage.prototype, "getItem")
+            .mockReturnValue("{\"showUnlabelledSessions\": false}");
+        spyOnSetItem = jest.spyOn(Storage.prototype, "setItem");
+    });
 
     beforeEach(() => {
         jest.clearAllMocks();
@@ -70,8 +80,12 @@ describe("localStorageManager gets and saves user preferences", () => {
 });
 
 describe("localStorageManager gets default user preferences", () => {
-    const spyOnGetItem = jest.spyOn(Storage.prototype, "getItem")
-        .mockReturnValue(null);
+    let spyOnGetItem: any;
+
+    beforeAll(() => {
+        spyOnGetItem = jest.spyOn(Storage.prototype, "getItem")
+            .mockReturnValue(null);
+    });
 
     beforeEach(() => {
         jest.clearAllMocks();