-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mrc-4609 Allow user to filter unlabelled sessions from view #194
Conversation
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Tested it out, works well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I do wonder if "Hide unlabelled sessions" (with a corresponding change in polarity of the box) might be easier to understand but the users can tell us that
Adds a checkbox allowing user to show or filter out unlabelled sessions from Sessions page. The user's selection is kept in local storage so it will be retained on next load (just as a global flag, not per app) and loaded to a
userPreferences
prop in the state. We default to showing unlabelled sessions.