Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrc-4609 Allow user to filter unlabelled sessions from view #194

Merged
merged 9 commits into from
Oct 23, 2023

Conversation

EmmaLRussell
Copy link
Contributor

@EmmaLRussell EmmaLRussell commented Sep 29, 2023

Adds a checkbox allowing user to show or filter out unlabelled sessions from Sessions page. The user's selection is kept in local storage so it will be retained on next load (just as a global flag, not per app) and loaded to a userPreferences prop in the state. We default to showing unlabelled sessions.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...tatic/src/app/components/sessions/SessionsPage.vue 100.00% <100.00%> (ø)
app/static/src/app/localStorageManager.ts 100.00% <100.00%> (ø)
app/static/src/app/store/appState/actions.ts 100.00% <100.00%> (ø)
app/static/src/app/store/appState/mutations.ts 100.00% <100.00%> (ø)
app/static/src/app/store/appState/state.ts 100.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@EmmaLRussell EmmaLRussell marked this pull request as ready for review October 11, 2023 13:05
Copy link
Collaborator

@M-Kusumgar M-Kusumgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tested it out, works well!

Copy link
Member

@richfitz richfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I do wonder if "Hide unlabelled sessions" (with a corresponding change in polarity of the box) might be easier to understand but the users can tell us that

@EmmaLRussell EmmaLRussell merged commit 14a0367 into main Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants