add script to pull wodin site #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 155 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
r-ash
approved these changes
Oct 24, 2023
docker/pull-site-and-start.sh
Outdated
| set -ex | ||
| HERE=$(dirname "$0") | ||
|
|
||
| git clone --branch $1 $2 $3 |
There was a problem hiding this comment.
You can use --single-branch here maybe too?
There was a problem hiding this comment.
ive decided to use --depth 1 instead, apparently this is better for bandwidth, see:
https://stackoverflow.com/questions/1778088/how-do-i-clone-a-single-branch-in-git?noredirect=1&lq=1
this was actually noticeably quicker on my machine, would definitely recommend --depth 1 if you just need to look at one branch
EmmaLRussell
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
LGTM, think you can give shift an argument rather than needing to call it three times: https://www.computerhope.com/unix/bash/shift.htm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a script I am adding for the wodin deploy tool to let it pull the wodin config from github before starting wodin in a container