mrc-4628 Filter out duplicate sessions from Sessions page #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaLRussell
changed the title
EmmaLRussell
commented
Oct 26, 2023
| @@ -283,9 +294,9 @@ export default defineComponent({ | |||
| window.location.assign(link); | |||
| }; | |||
|
|
|||
| onMounted(() => { | |||
| onMounted(async () => { | |||
| await store.dispatch(AppStateAction.LoadUserPreferences); | |||
There was a problem hiding this comment.
We need to load user preferences now before fetching sessions metadata as we use the duplicates preference in query string parameter to the endpoint.
EmmaLRussell
commented
Oct 27, 2023
|
|
||
| const saveMissingHashes = []; | ||
| // eslint-disable-next-line no-restricted-syntax | ||
| for await (const [idx, id] of ids.entries()) { |
There was a problem hiding this comment.
eslint doesn't like plain old fors but this is preferable for including async in the loop
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
M-Kusumgar
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch gives the user a checkbox to filter out duplicate sessions from the Sessions page (checked by default). Unlabelled sessions which are duplicates of a later session will not be shown. Labelled sessions are always shown (I think users would be confused if their labelled session vanished because a later session happened to be identical).
Now that we're saving hashes for sessions in order to identify duplicates, we could potentially make a further change to only save the data for a hash once, rather than for every session separately. One for another ticket: https://mrc-ide.myjetbrains.com/youtrack/issue/mrc-4677