-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mrc 5976 - use github actions and ghcr #232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mrc-5945 #232 +/- ##
============================================
- Coverage 99.78% 99.71% -0.07%
============================================
Files 160 185 +25
Lines 4109 4542 +433
Branches 936 985 +49
============================================
+ Hits 4100 4529 +429
- Misses 8 12 +4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
EmmaLRussell
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a couple of related things:
index.etest.ts
was using the same directory for all the tests so i have made it so each test is now fully independent of each otherfs.rmdirSync
is deprecated in node 20 so switched tofs.rmSync
as suggested by themstochastic.etest.ts
were being consistently flaky so made them reliable, basically there was another error in the.action-required-msg
element flashing so first we wait for that to go away and then testrun-version.sh
scriptcodecov.yml
file because codecov project failing because coverage has decreased by0.07%
is more pedantic than a mathematician except that codecov doesnt have nearly as many axioms, so we have the threshold to 2% just being acceptable, also our full project coverage is now 95-100% which is acceptable i thinkall tests/checks finish in less than 2m generally speaking :)