Last little fixes

README.md

@@ -30,11 +30,11 @@ Role Variables
  dumpall_guest_destination: "/tmp/ansible/dump/{{ inventory_hostname }}"
  dumpall_host_destination: "/tmp/ansible/dump/{{ inventory_hostname }}"
 
-The dumpall_keep_on_guest and dumpall_keep_on_host variables let you choose where you want to keep the dump file. The default setting is to keep files only on Ansible host.
+The `dumpall_keep_on_guest` and `dumpall_keep_on_host` variables let you choose where you want to keep the dump file. The default setting is to keep files only on Ansible host.
 
-The dumpall_guest_destination variable is where the dump file is created on the target. The dumpall_host_destination is where all dumps are retrieved from target.
+The `dumpall_guest_destination` variable is where the dump file is created on the target. The dumpall_host_destination` is where all dumps are retrieved from target.
 
-All variables are mandatory, and they are documented in default/main.yml.
+All variables are mandatory ( except for `dumpall_host_destination` ), and they are documented in default/main.yml.
 
 Example Playbook
 -------------------------

defaults/main.yml

@@ -12,6 +12,7 @@ dumpall_keep_on_host: yes
 # destination directory must already exists.
 dumpall_guest_destination: "/tmp/ansible_dump_{{ inventory_hostname }}"
 
-# Define here where you want to retrieve the dump file on the host.
+# Define here where you want to retrieve the dump file on the 
+# host. If this variable is not set, dumpall_keep_on_host is assumed to be False.
 dumpall_host_destination: "/tmp/ansible/dump/{{ inventory_hostname }}"
 

tasks/main.yml

@@ -4,7 +4,6 @@
  assert:
  that:
  - dumpall_guest_destination is defined
- - dumpall_host_destination is defined
  - dumpall_keep_on_guest is defined
  - dumpall_keep_on_host is defined
 
@@ -18,7 +17,9 @@
  src: "{{ dumpall_guest_destination }}"
  dest: "{{ dumpall_host_destination }}"
  flat: True
- when: dumpall_keep_on_host == True
+ when: >
+ dumpall_host_destination is defined and
+ dumpall_keep_on_host == True
 
 - name: Remove dumpfile on the guest
  file: