-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add basic USB-Camera support #10
Conversation
I've created #23 as feature request for this |
My thoughts regarding the implementation:
@mryel00 Let me know if you would like to have some help regarding the implementation |
Somehow I again forgot about the naming conventions 😅 |
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
Signed-off-by: Patrick Gehrsitz <mryel00.github@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
(Updated version)
This adds one new start parameter:
--camera_num
-n
to start spyglass with a specific camera. You can see all available cameras with the python commandPicamera2.global_camera_info()
. A start parameter to show this message should be added in the future.This also adds the ability to use USB cameras instead of only CSI (Pi cameras). The whole filestructure of cams got updated to make use of inheritance for that reason.
Note:
USB cams run terribly atm with libcamera and not all controls are available to use. Therefore they shouldn't be used with Spyglass.