This repository has been archived by the owner on Jan 30, 2019. It is now read-only.
Update MainPage.xaml.h #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfjelds
approved these changes
Jan 2, 2018
|
I verified the sample on both the DHT11 and DHT22 and the calculations were correct. I accepted a previous pull request that claimed to correct the math, but it was wrong and I had to revert the change. I'm sorry but I cannot accept this pull request without seeing the issue and fix firsthand. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have rewritten the 2 routines that return the decimal temp and humidity values from the received bitstring.
These were
double Humidity ( ) const
and
double Temperature ( ) const
in mainpagexaml.h
The math was all wrong and the program returned crazy values for both temp and humidity
Have added comments explaining the new code lines that are self explanatory.
tested and it works for DHT11- Difference for DHT22 should be that is more accurate and has decimal values