workaround JS bug returning incorrect conditional on YAML error

CHANGELOG.md

@@ -1,12 +1,12 @@
 ### 1.3.2 (Next)
 - Improve YAML syntax error message parsing.
 - Ignore irrelevant inventory and hosts warnings.
+- Workaround JS bug returning incorrect conditional on YAML error.
 
 bug in pulsar/ide-ui causing issues displaying yaml syntax message
 warnings no longer captured randomly
 update error-line-col, bad_include, missing_include because syntax-check no longer finding errors in general
-diagnostic missing message for temp fixture copied here
-task with only name emits uncaptured message
+js bug causes matchesYAMLError[1] message to not be captured (yaml_syntax fixture)
 
 ### 1.3.1
 - Updates to Linter API usage.

lib/main.js

@@ -120,17 +120,16 @@ export default {
             const matchesRange = /line\s(\d+),\scolumn\s(\d+)/.exec(output);
             let theRange = [[0, 0], [0, 1]];
 
-            // if this is a yaml syntax error, then replace the ansible error message with the yaml syntax error
-            let excerpt = matchesYAMLError == null ? matchesError[1] : matchesYAMLError[1];
-
             // parse range
             if (matchesRange != null) {
               theRange = [[Number.parseInt(matchesRange[1], 10) - 1, Number.parseInt(matchesRange[2], 10) - 1], [Number.parseInt(matchesRange[1], 10) - 1, Number.parseInt(matchesRange[2], 10)]];
             }
 
             toReturn.push({
               severity: 'error',
-              excerpt,
+              // if this is a yaml syntax error, then replace the ansible error message with the yaml syntax error
+              // there is a bizarre js bug occurring here due to obsolete node.js, and so null is checked on the first matcher instead
+              excerpt: matchesYAMLError[1] == null ? matchesError[1] : matchesYAMLError[1],
               location: {
                 file: theFile,
                 position: theRange,

package.json

@@ -10,11 +10,14 @@
     "linter",
     "ansible"
   ],
+  "scripts": {
+    "test": "pulsar --test spec"
+  },
   "bugs": {
     "url": "https://github.com/mschuchard/linter-ansible-syntax/issues"
   },
   "engines": {
-    "atom": ">0.95.0"
+    "pulsar": ">=1.0.0"
   },
   "providedServices": {
     "linter": {
@@ -39,7 +42,7 @@
         "error",
         {
           "ignore": [
-            "atom"
+            "pulsar"
           ]
         }
       ]
@@ -49,7 +52,7 @@
       "node": true
     },
     "globals": {
-      "atom": false
+      "pulsar": false
     }
   }
 }