misc cleanup

mschuchard · Sep 29, 2024 · 4b96e4a · 4b96e4a
1 parent 3ee9722
commit 4b96e4a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -13,7 +13,7 @@ on:
 
 jobs:
   lint:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     container: node:14-alpine
     steps:
     - name: checkout

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ### 1.6.3 (Next)
 - Warn on automatic formatting errors returned for non-config Terraform files.
+improve warn to only display non-config file issues?
+improve warn to only trigger when all issues derive from only non-config files?
+line/col parseint?
 
 ### 1.6.2
 - Refactor auto formatting config options.

diff --git a/lib/main.js b/lib/main.js
@@ -127,7 +127,7 @@ export default {
             if (!(/\.tf$/.exec(editorFile))) {
               // catch format errors and display as pulsar warning
               atom.notifications.addWarning(
-                'An error occurred during automatic formatting.',
+                'An error occurred during automatic formatting of a non-config file.',
                 {
                   detail: error.message,
                   dismissable: true
@@ -144,7 +144,7 @@ export default {
           // parse json output
           const info = JSON.parse(output);
           // assign formatVersion for future use
-          const formatVersion = info.format_version;
+          // const formatVersion = info.format_version;
 
           // command is reporting an issue
           if (info.valid === false) {

diff --git a/spec/fixtures/bad_tfvars/test.tfvars b/spec/fixtures/bad_tfvars/test.tfvars
@@ -0,0 +1 @@
+foo         = "bar