-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm64: dts: qcom: msm8916-samsung-j5-common: Upstreaming #258
arm64: dts: qcom: msm8916-samsung-j5-common: Upstreaming #258
Conversation
a154b79
to
90b1f97
Compare
|
||
led-max-microamp = <300000>; | ||
flash-max-microamp = <1500000>; | ||
flash-max-timeout-us = <1835000>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious mostly, where are these values coming from? Or are they just made up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainl1ne@20c0f7c#diff-92c2357e6d8e3028d5884f443969796f7d690bd991dc913f8f1fdd23575c14b2R219-R221
They are copied values and I am not sure what they do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @nergzd723 can share where they are coming from. I failed to find them in a obvious way downstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe downstream KTD2692_MOVIE_CURRENT4 and KTD2692_FLASH_CURRENT16 would match those values. I don't remember how I converted it to uA, exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't really understand it, but I guess I'm fine with it as long as you make sure that it works properly :)
90b1f97
to
aed7cf5
Compare
aed7cf5
to
50db6ab
Compare
a91a84b
to
e0f0936
Compare
e0f0936
to
7e5ac50
Compare
7e5ac50
to
b7bbeb3
Compare
b7bbeb3
to
38a761c
Compare
I'm not sure what happened, but testing the modified source from on my SM-J500H (3g variant, codename j5), the touchscreen works, but the modem seems to not work, specifically it doesn't detect my SIM card, but otherwise seems to work fine. |
@ap4ss3rby I don't see modem regressions for now. Does it always or sometimes happen? |
Well I was testing with a nanoSIM, and since the phone has a slot loading microSIM I wasn't pushing the sim into the socket completely, so it seems like its mostly my fault for not inserting it fully (or not using a SIM adapter), otherwise it seems to be working fine (including only recognizing that my phone is 3g only) |
38a761c
to
e35c6f4
Compare
063bbd9
to
8990bb5
Compare
8990bb5
to
34242d4
Compare
20b1650
to
4f969ef
Compare
Add a new test case which performs double query of the bpf_mprog through libbpf API, but also via raw bpf(2) syscall. This is testing to gather first the count and then in a subsequent probe the full information with the program array without clearing passed structs in between. # ./vmtest.sh -- ./test_progs -t tc_opts [...] ./test_progs -t tc_opts [ 1.398818] tsc: Refined TSC clocksource calibration: 3407.999 MHz [ 1.400263] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x311fd336761, max_idle_ns: 440795243819 ns [ 1.402734] clocksource: Switched to clocksource tsc [ 1.426639] bpf_testmod: loading out-of-tree module taints kernel. [ 1.428112] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel #252 tc_opts_after:OK #253 tc_opts_append:OK #254 tc_opts_basic:OK #255 tc_opts_before:OK #256 tc_opts_chain_classic:OK #257 tc_opts_chain_mixed:OK #258 tc_opts_delete_empty:OK #259 tc_opts_demixed:OK #260 tc_opts_detach:OK #261 tc_opts_detach_after:OK #262 tc_opts_detach_before:OK #263 tc_opts_dev_cleanup:OK #264 tc_opts_invalid:OK #265 tc_opts_max:OK #266 tc_opts_mixed:OK #267 tc_opts_prepend:OK #268 tc_opts_query:OK <--- (new test) #269 tc_opts_replace:OK #270 tc_opts_revision:OK Summary: 19/0 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/r/20231006220655.1653-4-daniel@iogearbox.net Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Add a new test case to query on an empty bpf_mprog and pass the revision directly into expected_revision for attachment to assert that this does succeed. ./test_progs -t tc_opts [ 1.406778] tsc: Refined TSC clocksource calibration: 3407.990 MHz [ 1.408863] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x311fcaf6eb0, max_idle_ns: 440795321766 ns [ 1.412419] clocksource: Switched to clocksource tsc [ 1.428671] bpf_testmod: loading out-of-tree module taints kernel. [ 1.430260] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel #252 tc_opts_after:OK #253 tc_opts_append:OK #254 tc_opts_basic:OK #255 tc_opts_before:OK #256 tc_opts_chain_classic:OK #257 tc_opts_chain_mixed:OK #258 tc_opts_delete_empty:OK #259 tc_opts_demixed:OK #260 tc_opts_detach:OK #261 tc_opts_detach_after:OK #262 tc_opts_detach_before:OK #263 tc_opts_dev_cleanup:OK #264 tc_opts_invalid:OK #265 tc_opts_max:OK #266 tc_opts_mixed:OK #267 tc_opts_prepend:OK #268 tc_opts_query:OK #269 tc_opts_query_attach:OK <--- (new test) #270 tc_opts_replace:OK #271 tc_opts_revision:OK Summary: 20/0 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/r/20231006220655.1653-6-daniel@iogearbox.net Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
4f969ef
to
4a67436
Compare
8cc957b
to
8c4a987
Compare
4a67436
to
a3b8927
Compare
a3b8927
to
a23db8e
Compare
98939cb
to
c4d3662
Compare
a23db8e
to
286951b
Compare
e7a0931
to
903e6f0
Compare
286951b
to
0b0b520
Compare
19cb01e
to
349abab
Compare
0b0b520
to
d69fe2e
Compare
224cef4
to
f8e8fc2
Compare
d69fe2e
to
66e6840
Compare
There are regressions found in KTD2692 driver. b5a8c50 needs to be reverted to get front torch working. |
eb39f23
to
fc59a46
Compare
66e6840
to
2fe97a1
Compare
77359bc
to
f1299dc
Compare
2fe97a1
to
3d7ef2e
Compare
3d7ef2e
to
a886c4f
Compare
a886c4f
to
de069af
Compare
AddDrop j3 in upstreamsamsung-j3
to upstream, and include it inmsm8916-mainline
Add touchscreen to upstream patches Drop touchscreen in upstreamUpstreamed touchscreen partially.msm8916-samsung-j3-common.dtsi
Link:
https://lore.kernel.org/lkml/20230106142748.546975-1-linmengbo0689@protonmail.com/
https://lore.kernel.org/lkml/20230715214046.14902-1-linmengbo0689@protonmail.com/
https://lore.kernel.org/lkml/20230904123123.2593-1-linmengbo0689@protonmail.com/