fix cases where commuting probability for car and transit is 0 and th…

…e ratio becomes N/A, leading to in infinite loop
msmobility · Dec 4, 2019 · 1652b72 · 1652b72
1 parent c53f2cb
commit 1652b72
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/siloCore/src/main/java/de/tum/bgu/msm/models/modeChoice/SimpleCommuteModeChoice.java b/siloCore/src/main/java/de/tum/bgu/msm/models/modeChoice/SimpleCommuteModeChoice.java
@@ -65,8 +65,13 @@ public CommuteModeChoiceMapping assignCommuteModeChoice(Location from, TravelTim
                     utilityByMode.put(TransportMode.car, carUtility);
                     utilityByMode.put(TransportMode.pt, ptUtility);
                     commuteModesByPerson.put(pp.getId(), utilityByMode);
-                    double probabilityAsKey = carUtility / (carUtility + ptUtility);
-                    while (personByProbability.containsKey(probabilityAsKey)){
+                    double probabilityAsKey;
+                    if(carUtility == 0 && ptUtility == 0) {
+                        probabilityAsKey = 0.5;
+                    } else {
+                        probabilityAsKey = carUtility / (carUtility + ptUtility);
+                    }
+                    while (personByProbability.containsKey(probabilityAsKey)) {
                         //more than one hh member has exactly the same probability, so it would be replaced in the treemap
                         probabilityAsKey += random.nextDouble();
                     }
@@ -125,8 +130,13 @@ public CommuteModeChoiceMapping assignRegionalCommuteModeChoice(Region region, T
                     utilityByMode.put(TransportMode.car, carUtility);
                     utilityByMode.put(TransportMode.pt, ptUtility);
                     commuteModesByPerson.put(pp.getId(), utilityByMode);
-                    double probabilityAsKey = carUtility / (carUtility + ptUtility);
-                    if (personByProbability.containsKey(probabilityAsKey)){
+                    double probabilityAsKey;
+                    if(carUtility == 0 && ptUtility == 0) {
+                        probabilityAsKey = 0.5;
+                    } else {
+                        probabilityAsKey = carUtility / (carUtility + ptUtility);
+                    }
+                    while (personByProbability.containsKey(probabilityAsKey)) {
                         //more than one hh member has exactly the same probability, so it would be replaced in the treemap
                         probabilityAsKey += random.nextDouble();
                     }