fix: narrow body type for HttpResponse.json() to be serializable json
#1838
Conversation
kettanaito
changed the title
ReadableStream body to HttpResponse.json()ReadableStream body to HttpResponse.json()
kettanaito
changed the title
ReadableStream body to HttpResponse.json()body type for HttpResponse.json() to be serializable json
kettanaito
changed the title
body type for HttpResponse.json() to be serializable jsonbody type for HttpResponse.json() to be serializable json
| @@ -19,6 +19,14 @@ export type DefaultBodyType = | |||
| | null | |||
| | undefined | |||
|
|
|||
| export type JsonBodyType = | |||
| | Record<string, any> | |||
There was a problem hiding this comment.
nit: do we want to be slightly more prescriptive than Record<string, any> here, Record<string, JsonBodyType> might be the most correct option?
also I think we'd need to account for Array<JsonBodyType> too? (and potentially their readonly varieties?)
There was a problem hiding this comment.
Surprisingly, TypeScript is permissive about this and arrays extend Record<string, any> quite well. It's the any part that does the trick.
As to narrowing down the type from any to a recursive JsonBodyType, I'm not so sure about it. It sounds like the right thing to do but there's always corner cases people run into, and it's hard to predict what will happen if we make this body type that strict.
Released: v2.0.4 🎉This has been released in v2.0.4! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Changes
bodytype of theHttpResponse.json()static method must be a serializable JSON. Narrow the argument type to reflect that.JsonBodyTypetype from the core.