fix(graphql): allow null for "data" and "errors" response property types #1867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, providing
null
as the value ofdata
orerrors
properties on the mocked GraphQL response causes a TypeScript error. That's because the types for those properties don't have the union withnull
:msw/src/core/handlers/GraphQLHandler.ts
Lines 52 to 55 in 28efd32
This also makes them incompatible with the
ExecutionResult
from thegraphql
package.