fix: inject node:event dependencies through SetupServerApi first argument in constructor
#1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcosta7
changed the title
SetupServerApi first argument in constructor
kettanaito
reviewed
Nov 22, 2023
| new (): Interceptor<HttpRequestEventMap> | ||
| }>, | ||
| interceptorsOrConfig: | ||
| | Interceptors |
There was a problem hiding this comment.
I'm not a fan of overly dynamic call signatures. Node has had enough of me. I think your approach to solve this problem in #1879 is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative take on #1879
This uses a modified first argument to SetupServerApi that optionally uses a config object instead of a straight array of interceptors.
Ideally, i think an api like
SetupServerApi(interceptors, config, ...handlers)might be clearer, but that would be a breaking change I'm trying to avoid, and the pure additive approach here seems reasonable as an iterative stepI don't have a strong preference between this version and the one in the other referenced pr, which provides a context setter