Fix mailto in html entites used on github profile page

mtibben · Apr 16, 2020 · 7d78d00 · 7d78d00
1 parent d484bce
commit 7d78d00
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/Html2Text.php b/src/Html2Text.php
@@ -426,7 +426,7 @@ protected function buildlinkList($link, $display, $linkOverride = null)
  }
 
  // Ignored link types
- if (preg_match('!^(javascript:|mailto:|#)!i', $link)) {
+ if (preg_match('!^(javascript:|mailto:|#)!i', html_entity_decode($link))) {
  return $display;
  }
 

diff --git a/test/LinkTest.php b/test/LinkTest.php
@@ -159,4 +159,24 @@ public function testDoLinksWhenTargetInText()
 
  $this->assertEquals($expected, $html2text->getText());
  }
+
+ public function testMailto()
+ {
+ $html = '<a href="mailto:example@example.com">Link text</a>';
+ $expected = 'Link text';
+
+ $html2text = new Html2Text($html, array('do_links' => 'inline'));
+
+ $this->assertEquals($expected, $html2text->getText());
+ }
+
+ public function testMailtoWithEntity()
+ {
+ $html = '<a href="&#109;&#97;&#105;&#108;&#116;&#111;&#58;example@example.com">Link text</a>';
+ $expected = 'Link text';
+
+ $html2text = new Html2Text($html, array('do_links' => 'inline'));
+
+ $this->assertEquals($expected, $html2text->getText());
+ }
 }