Explicitly list extras as dependency #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is imported after all.. Closes mtreinish#347
|
AFAIU next release could happen soon (#345 ), would be great to get this fix there as well |
|
looks like there are some other parts that have to be adjusted, e.g. https://github.com/mtreinish/stestr/blob/main/stestr/tests/test_subunit_trace.py#L25 because new subunit uses external iso lib testing-cabal/subunit@91b07aa |
python-subunit stopped vendoring it in, so we must install our own version too.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 61.79% 61.79%
=======================================
Files 30 30
Lines 2625 2625
Branches 428 428
=======================================
Hits 1622 1622
Misses 884 884
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mtreinish
approved these changes
Sep 18, 2023
tanaypf9
pushed a commit
to tanaypf9/pf9-requirements
that referenced
this pull request
May 20, 2024
stestr has an indrect dep on testtools[extras] that was previously included with testtools 2.5.0 via python-subunit? this now causes issues with stestr following the release of 2.6.0 and python-subunit 1.4.3 mtreinish/stestr#347 mtreinish/stestr#350 lets clmap both python-subunit and testtool until stestr can be updated. mtreinish/stestr#348 and that can be released. Change-Id: I7df39f385fc8e0b54f7034b3a84dbaadbc6bbbff
tanaypf9
pushed a commit
to tanaypf9/pf9-requirements
that referenced
this pull request
May 20, 2024
stestr has an indrect dep on testtools[extras] that was previously included with testtools 2.5.0 via python-subunit? this now causes issues with stestr following the release of 2.6.0 and python-subunit 1.4.3 mtreinish/stestr#347 mtreinish/stestr#350 lets clmap both python-subunit and testtool until stestr can be updated. mtreinish/stestr#348 and that can be released. Change-Id: I7df39f385fc8e0b54f7034b3a84dbaadbc6bbbff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is imported after all..
Closes #347