Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: make repo initialization respect pyproject.toml #352

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Bugfix: make repo initialization respect pyproject.toml #352

merged 1 commit into from
Oct 24, 2023

Conversation

0xDEC0DE
Copy link
Contributor

Make the repo initialization step look for all supported config formats before giving up.

Fixes: Issue #351

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #352 (de16165) into main (96ccf24) will increase coverage by 0.16%.
The diff coverage is 20.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   61.79%   61.95%   +0.16%     
==========================================
  Files          30       30              
  Lines        2625     2618       -7     
  Branches      428      426       -2     
==========================================
  Hits         1622     1622              
+ Misses        884      877       -7     
  Partials      119      119              
Flag Coverage Δ
unittests 61.95% <20.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
stestr/commands/run.py 42.75% <20.00%> (+1.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Make the repo initialization step look for all supported config
formats before giving up.

Fixes: Issue #351
@0xDEC0DE
Copy link
Contributor Author

I have no earthly idea what codecov wants me to do here. I have increased coverage, but it's still mad at me.

Copy link
Owner

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this. Don't worry about codecov I think it's just confused because the measured code just had more removals than additions. I thought we had the checks with red x's disabled tbh, we try to treat coverage as informative and not a gating check. I'll check the settings for it.

@mtreinish mtreinish merged commit 282e99b into mtreinish:main Oct 24, 2023
19 of 20 checks passed
@0xDEC0DE 0xDEC0DE deleted the issue/351 branch October 24, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants