Skip to content

Commit

Permalink
Merge pull request #40 from muak/fixPickerCell#39
Browse files Browse the repository at this point in the history
fix PickerCell
  • Loading branch information
muak authored Sep 6, 2018
2 parents fd19ac0 + ab252db commit 3c17a39
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions SettingsView.iOS/Cells/PickerCellRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ protected override void Dispose(bool disposing)
_notifyCollection.CollectionChanged -= ItemsSourceCollectionChanged;
_notifyCollection = null;
}
if (_selectedCollection != null)
{
_selectedCollection.CollectionChanged -= SelectedItems_CollectionChanged;
_selectedCollection = null;
}
}
base.Dispose(disposing);
}
Expand Down
4 changes: 2 additions & 2 deletions nuget/SettingsView_mac.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
<metadata>
<id>AiForms.SettingsView</id>
<version>0.2.9</version>
<version>0.3.0</version>
<title>SettingsView for Xamarin.Forms</title>
<authors>kamu</authors>
<owners>kamu</owners>
Expand All @@ -16,7 +16,7 @@ There are various cells such as (LabelCell,ButtonCell,CommandCell,SwitchCell,Che
<releaseNotes>
## Bug fixes

* [PickerCell] When the SelectedItems is changed programmatically, the new value text is not shown. (#16)
* [PickerCell] When opening two times, a null exception occurs. (#39)
</releaseNotes>
<tags>Xamarin.Forms TableView Cell Setting Configuration Option ListView UITableView RecyclerView ReOrder DragDrop</tags>
<language>en-US</language>
Expand Down

0 comments on commit 3c17a39

Please sign in to comment.