You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to follow Joy UI's implementation, but also deviated quite a bit from it. I removed a memoTheme to get access to ownerState, in the same way as Joy UI, but I am not sure if it is the solution we want to go with. I could go back to the props based solution, if that is preferred. I tried the Joy UI way with ownerState, but it caused builds to fail, so I stayed on the memoTheme with props solution. Furthermore, I also made some assumptions about relations between variables and the magic constants currently present, which might require some looking over. For the SliderMarkLabel I did not see any clear correlations, except for maybe the left property aligning with the paddingRight from root on the vertical variant, so I just left the values as constants for now, but that should likely be changed.
albarv340
changed the title
[Slider][material-ui] Refactor style to use CSS variables
[material-ui][Slider] Refactor style to use CSS variables
Sep 27, 2024
component: sliderThis is the name of the generic UI component, not the React module!
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
albarv340
changed the title
zannager
added
the
component: slider
Closes #38981