Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Dialog] Fix Keyboard scrolling doesn't work in fullscreen modal ( #42989 ) #43934

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[material-ui][Dialog] Fix Keyboard scrolling doesn't work in fullscreen modal ( #42989 ) #43934

wants to merge 2 commits into from
+30 −1

Conversation

essaysir
Copy link

fixed #42989

Summary

  • When in fullscreen mode, event.target.scrollHeight and event.target.clientHeight are equal, preventing any scrolling.
    To address this:
  1. If rootRef.current is scrollable, we now focus on the existing rootRef.current.
  2. If rootRef.current is not scrollable, we find and focus on the first scrollable child element.

This modification ensures proper focus and scrolling behavior in fullscreen scenarios.

AS-IS

2024-09-29.3.17.05.mov

TO-BE

2024-09-29.3.15.46.mov

@mui-bot
Copy link

mui-bot commented Sep 29, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43934--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 85aa4df

@essaysir essaysir mentioned this pull request Sep 29, 2024
Open
@zannager zannager added the component: dialog This is the name of the generic UI component, not the React module! label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli Awaiting requested review from ZeeshanTamboli

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[material-ui][Dialog] Keyboard scrolling doesn't work in fullscreen mode
3 participants
@essaysir @mui-bot @zannager