[material-ui][TextareaAutosize] Temporarily disconnect ResizeObserver to avoid loop error #44540
+56
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
force-pushed
the
fix/textarea-ro-loop
branch
from
e712092 to
e2d5825
Compare
Netlify deploy previewhttps://deploy-preview-44540--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mj12albert
force-pushed
the
fix/textarea-ro-loop
branch
5 times, most recently
from
b152a03 to
72a6aaa
Compare
mj12albert
changed the title
mj12albert
force-pushed
the
fix/textarea-ro-loop
branch
from
72a6aaa to
d140f30
Compare
mj12albert
force-pushed
the
fix/textarea-ro-loop
branch
from
d140f30 to
044a802
Compare
mj12albert
requested review from
mnajdova,
michaldudak and
aarongarciah
and removed request for
michaldudak
mj12albert
commented
Nov 25, 2024
| @@ -36,15 +36,20 @@ type TextareaStyles = { | |||
| overflowing: boolean; | |||
| }; | |||
|
|
|||
| function isObjectEmpty(object: TextareaStyles) { | |||
There was a problem hiding this comment.
mj12albert
force-pushed
the
fix/textarea-ro-loop
branch
2 times, most recently
from
5b99446 to
3a7aaf2
Compare
aarongarciah
changed the title
|
@mj12albert since this was hard to reproduce and might have some edge cases, can you add a comment in the related issue (#43718) to see if some users can test with this PR's version? They'd need to install |
Added ~ #43718 (comment) |
mj12albert
force-pushed
the
fix/textarea-ro-loop
branch
6 times, most recently
from
e2af729 to
cdaa830
Compare
mj12albert
force-pushed
the
fix/textarea-ro-loop
branch
2 times, most recently
from
44de4da to
b571946
Compare
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
fix/textarea-ro-loop
branch
from
b571946 to
b540ceb
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
fix/textarea-ro-loop
branch
3 times, most recently
from
d84fef6 to
239b54b
Compare
mj12albert
force-pushed
the
fix/textarea-ro-loop
branch
from
239b54b to
5196ed1
Compare
mj12albert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43718
Fixes #44140
Demo: https://codesandbox.io/p/sandbox/immutable-architecture-nslxvr?file=%2Fsrc%2FApp.js%3A33%2C1 (forked from the original repro)
This was very hard to repro locally, but I believe the "loop" is caused when we change the height of the element in the RO callback, while it is still being observed, which fires the callback again (and again…)
The fix is to un-observe the element, manipulate the height then re-observe one frame later, instead of manipulating the height one frame later suggested here (or here).