Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python patch versions #523

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Update Python patch versions #523

merged 2 commits into from
Aug 22, 2024

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Aug 22, 2024

Update Python 3.8 to 3.12 patch versions to there latest versions.

osx_utils.sh Outdated
LATEST_3p12=3.12.0
LATEST_3p8=3.8.19
LATEST_3p9=3.9.19
LATEST_3p10=3.10.14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python 3.11 and 3.12 changes are fine, but these other versions shouldn't actually be updated. They are the versions for the latest binary download - see the extra files at https://www.python.org/ftp/python/3.10.11/ vs https://www.python.org/ftp/python/3.10.14/, and

multibuild/osx_utils.sh

Lines 177 to 186 in b5e75d5

if [ "$(uname -m)" == "arm64" ] || [ $(lex_ver $py_version) -ge $(lex_ver 3.10.0) ]; then
if [ "$py_version" == "3.9.1" ]; then
echo "python-${py_version}-macos11.0.${inst_ext}"
else
echo "python-${py_version}-macos11.${inst_ext}"
fi
else
local py_osx_ver=${2:-$(macpython_sdk_for_version $py_version)}
echo "python-${py_version}-macosx${py_osx_ver}.${inst_ext}"
fi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for explaining!

Updated, feel free to squash the commits in this PR while merging.

They're already on their latest versions for which a binary download it available.
@mattip mattip merged commit f876f1d into multi-build:devel Aug 22, 2024
2 of 3 checks passed
@mattip
Copy link
Collaborator

mattip commented Aug 22, 2024

Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants