Honor BUILD_PREFIX in giflib builds #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, thanks. I assume you tested this out and it now works as advertised? |
|
Yes - I've been using this part of my work on getting iOS builds working; in that context, you need to have a standalone build prefix for iOS dependencies, rather than installing into /usr, /usr/local or similar. So far, giflib has been the only recipe that has needed modification (out of the set used by Pillow, anyway) |
radarhere
changed the title
|
Thanks @freakboy3742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build recipe for
giflibwill unconditionally install into/usr/local/bin, the default installation prefix for the "makefile only" giflib project.This PR modifies the
giflibbuild recipe to use the value ofBUILD_PREFIX, matching the behavior of other recipes.