-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle valid CIDR ranges for IPv4 and IPv6 #394
Conversation
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we want more resilient tests here, but they don't break current tests and pass with the /128
which fixes #393
approving, lgtm..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would be better to have more comprehensive tests but it fixes the case that's currently broken.
## [12.3.4](v12.3.3...v12.3.4) (2024-12-03) ### Bug Fixes * handle valid CIDR ranges for IPv4 and IPv6 ([#394](#394)) ([1513768](1513768))
🎉 This PR is included in version 12.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@SgtPooki @achingbrain @MarcoPolo
Add missing case 43 (ipcidr) to
convert.ts
to properly handle CIDR rangesAdd two new test cases
Issue: Unexpected SyntaxError for valid ipcidr ranges