fix: assume dns4 for domain names #2
Conversation
- switch the defualt protocol for domain names from dnsaddr to dns4 - provide an override to let the caller pick the default protocol for domains License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
There was a problem hiding this comment.
This library assumes
/dns4when it finds a domain name in the input string. It makes no attempt query DNS. To override the default assumption, you can pass in an options object as the second parameter to override it
This should be a safe default given current reality that ipv6 websites are a subset of ipv4 ones, and the library will be primarily used in frontend places like ipfs-webui, where dns resolution is handled by the browser anyway.
cc @lgierth as he is familiar with historical decisions related to /dns4, /dns6 and /dnsaddr
| ['/dnsaddr/ipfs.io/ws', 'ws://ipfs.io'], | ||
| ['/dnsaddr/ipfs.io/http', 'http://ipfs.io'], | ||
| ['/dnsaddr/ipfs.io/https', 'https://ipfs.io'], | ||
| ['/dns4/protocol.ai/tcp/80', 'tcp://protocol.ai:80'], |
There was a problem hiding this comment.
I would add the same /dns6/ entries as well, just for completeness.
There was a problem hiding this comment.
@lidel there is a seperaste test for the defaultDnsType below, is that what you were looking for?
Co-Authored-By: olizilla <oli@tableflip.io>
|
looking at it now, I think the current defacto way of expressing https is to nest http in tls... |
|
@olizilla see my note about |
A better fix for this will be possible once multiformats/multiaddr#22 is decided.
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io