-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Project Structure in README #273
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
✅ Deploy Preview for multiverse-dataverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from Dataverse
team will review it as soon as possible. We appreciate your support in making this project better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siri-chandana-macha you have added the structure in Readme file, which makes it long unnecessarily, also does this structure update automatically as many files will be added, deleted or renamed in future. Checkout the project structure in my other project, that is what should be done here too.
- Give a link to the `project structure file in readme,md.
- the structure should update automatically.
Good luck fixing the stated issue. You can ask if you have any doubts.
No it does not auto update
…On Tue, 5 Nov, 2024, 12:57 am Tejas Gupta, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@siri-chandana-macha <https://github.com/siri-chandana-macha> you have
added the structure in Readme file, which makes it long unnecessarily, also
does this structure update automatically as many files will be added,
deleted or renamed in future. Checkout the project structure in my other
project
<https://github.com/multiverseweb/CodeIt?tab=readme-ov-file#-project-structure>,
that is what should be done here too.
- Give a link to the `project structure file in readme,md.
- the structure should update automatically.
Good luck fixing the stated issue. You can ask if you have any doubts.
—
Reply to this email directly, view it on GitHub
<#273 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BK7ODR5YQFE37K3GB7VZOSDZ67DBTAVCNFSM6AAAAABRCMBK42VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJTHEZTEMJRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I will add in a separate file
On Tue, 5 Nov, 2024, 5:53 am Siri chandana Macha, ***@***.***>
wrote:
… No it does not auto update
On Tue, 5 Nov, 2024, 12:57 am Tejas Gupta, ***@***.***>
wrote:
> ***@***.**** requested changes on this pull request.
>
> @siri-chandana-macha <https://github.com/siri-chandana-macha> you have
> added the structure in Readme file, which makes it long unnecessarily, also
> does this structure update automatically as many files will be added,
> deleted or renamed in future. Checkout the project structure in my other
> project
> <https://github.com/multiverseweb/CodeIt?tab=readme-ov-file#-project-structure>,
> that is what should be done here too.
>
> - Give a link to the `project structure file in readme,md.
> - the structure should update automatically.
>
> Good luck fixing the stated issue. You can ask if you have any doubts.
>
> —
> Reply to this email directly, view it on GitHub
> <#273 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BK7ODR5YQFE37K3GB7VZOSDZ67DBTAVCNFSM6AAAAABRCMBK42VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJTHEZTEMJRGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
@multiverseweb Yeah its long. I have added the Project Structure in a seperate file. |
There is a workflow for this right. I will update it |
@siri-chandana-macha Resolve conflicts. |
@multiverseweb I tried to create workflow for project structure but it's not working so please consider this manually made one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @siri-chandana-macha, the automated workflow has been added in the PR #313, therefore I can't merge this manual structure as changes will be made in the project structure continuously.
I hope you understand. Let me know if you want to discuss this further.
Good luck!
Description
I have added the Project Structure to the README . This guides contributors on where specific files and folders are located and what they contain.
Related Issue
Fixes #271
Note: @multiverseweb please make sure to add all the necessary labels in #271