Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new epoch start blockchain hooks #6548

Open
wants to merge 35 commits into
base: rc/barnard
Choose a base branch
from
Open

new epoch start blockchain hooks #6548

wants to merge 35 commits into from

Conversation

laurci
Copy link
Contributor

@laurci laurci commented Oct 21, 2024

Reasoning behind the pull request

New blockchain hooks added:

  • RoundTime hook
  • EpochStartBlockTimeStamp hook
  • EpochStartBlockNonce hook
  • EpochStartBlockRound hook

Proposed changes

  • update mx-chain-vm-go mx-chain-vm-common-go and related mods
  • implementation for the new hooks

Testing procedure

Pre-requisites

Related PRs:

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

laurci and others added 27 commits July 16, 2024 13:45
@laurci
add new blockchain hooks
a7e9294
@laurci
Merge remote-tracking branch 'origin/rc/v1.7.next1' into new-blockcha…
9ff3ca2 
…in-hooks
@laurci
Merge remote-tracking branch 'origin/rc/v1.7.2' into new-blockchain-h…
67a99d6 
…ooks
@laurci
use cached epoch start block in vm blockchain hook
f060fde
@laurci
tpn nil epoch start trigger
a4b93be
@laurci
use round handler to get round duration in blockchain hook
c8ef463
@laurci
fix nil pointer epoch start block header
9334561
@laurci
nil checks for RoundHandler and EpochStartTriggerHandler
b9eef0c
@laurci
fix more RoundHandler nils in tests
f94bc3c
@laurci
deep copy header when returning from trigger
8d9114d
@laurci
epochStartHdr nil error check
0684c29
@laurci
propagate SetCurrentHeader errors
53f4563
@laurci
remove log; epoch start hdr check if nil
0534fc4
@laurci
simplify error handling in LastCommitedEpochStartHdr impl
1f07ae2
@laurci
get epoch start block from storage for sc query
1877e0c
@laurci
add comment for SetEpochStartHeader
6f64220
@laurci
rc/1.7.2 update dependencies
a333893
@laurci
managed buffer small ints gas cost
fc46b8b
@laurci
formatting fixes
5d877d8
@laurci
update vm version
4ac3ab5
@laurci
chainsimulator tests fixes
a6a1af7
@laurci
more chain simulator tests fixing
e770491
@laurci
add warn logs for error cases in updateEpochStartHeaderFromCurrentHeader
2a402b5
@laurci
Merge remote-tracking branch 'origin/rc/barnard' into new-blockchain-…
bc949a7 
…hooks
@sasurobert
fixes after merge
98a24b2
@sasurobert
delete files
96d4de0
@sasurobert
Merge branch 'spica-to-barnard-23-okt' into new-blockchain-hooks
dc39f02 
# Conflicts:
#	go.mod
#	go.sum
#	testscommon/esdtStorageHandlerStub.go
@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@sasurobert
Merge branch 'spica-to-barnard-23-okt' into new-blockchain-hooks
4a2031b 
# Conflicts:
#	factory/interface.go
#	factory/mock/processComponentsStub.go
#	factory/processing/export_test.go
#	factory/processing/processComponents.go
#	factory/processing/txSimulatorProcessComponents.go
#	factory/processing/txSimulatorProcessComponents_test.go
#	go.mod
#	go.sum
#	integrationTests/mock/processComponentsStub.go
#	node/chainSimulator/components/processComponents.go
#	node/node_test.go
#	testscommon/components/default.go
@sasurobert
merges
71dcf66
@sasurobert
Merge branch 'rc/barnard' into new-blockchain-hooks
0ae6ede
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@github-actions GitHub Actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 6af33da779df07952cef2bc56ae0d11b750ec751
  • Current Branch: new-blockchain-hooks
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 11112024-151833
  • PYTEST_EXIT_CODE: 1
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions GitHub Actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 546265919c328a1ead71be36f3d85d7d2e4d4f0e
  • Current Branch: new-blockchain-hooks
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 12112024-142304
  • PYTEST_EXIT_CODE: 1
    🎉 MultiversX CI/CD Workflow Complete!

@laurci
Copy link
Contributor Author

laurci commented Nov 12, 2024

Run Tests:
mx-chain-simulator-go: new-blockchain-hooks-barnard

@github-actions GitHub Actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 546265919c328a1ead71be36f3d85d7d2e4d4f0e
  • Current Branch: new-blockchain-hooks
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: new-blockchain-hooks-barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 12112024-144027
  • PYTEST_EXIT_CODE: 1
    🎉 MultiversX CI/CD Workflow Complete!

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 30.27027% with 129 lines in your changes missing coverage. Please review.

Please upload report for BASE (rc/barnard@7979558). Learn more about missing BASE report.

Files with missing lines Patch % Lines
process/smartContract/hooks/blockChainHook.go 25.42% 42 Missing and 2 partials ⚠️
epochStart/metachain/trigger.go 0.00% 19 Missing ⚠️
process/smartContract/scQueryService.go 43.75% 11 Missing and 7 partials ⚠️
node/chainSimulator/chainSimulator.go 0.00% 15 Missing ⚠️
epochStart/shardchain/trigger.go 0.00% 13 Missing ⚠️
process/block/metablock.go 22.22% 5 Missing and 2 partials ⚠️
factory/processing/processComponentsHandler.go 0.00% 4 Missing ⚠️
process/block/shardblock.go 33.33% 2 Missing and 2 partials ⚠️
...ode/chainSimulator/components/processComponents.go 0.00% 3 Missing ⚠️
...ocess/transactionEvaluator/transactionSimulator.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             rc/barnard    #6548   +/-   ##
=============================================
  Coverage              ?   78.59%           
=============================================
  Files                 ?      753           
  Lines                 ?    99468           
  Branches              ?        0           
=============================================
  Hits                  ?    78180           
  Misses                ?    16003           
  Partials              ?     5285

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: cd27078a2e12b335f0d1478645669c2333d6e37f
  • Current Branch: new-blockchain-hooks
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 13112024-160241
  • PYTEST_EXIT_CODE: 1
    🎉 MultiversX CI/CD Workflow Complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurci @sasurobert