[sovereign] Disable notifier registration until fully synced #6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axenteoctavian
previously approved these changes
Nov 4, 2024
sasurobert
reviewed
Nov 6, 2024
| log.Debug("notifierBootstrapper.checkNodeState: worker's go routine is stopping...") | ||
| return | ||
| case <-nb.nodeSyncedChan: | ||
| err := nb.sovereignNotifier.RegisterHandler(nb.incomingHeaderHandler) |
There was a problem hiding this comment.
this is quite a problem is register is failing.
Can't we design in such a way that the node stops ?
There was a problem hiding this comment.
Changed it as requested to signal the node to stop if registration fails
…MX-15963-disable-notifier-until-synced
Base automatically changed from
MX-15962-chain-sim-test-incoming-header-finality
to
feat/sovereign-mainchain-header-sync
November 7, 2024 14:44
mariusmihaic
dismissed
axenteoctavian’s stale review
The base branch was changed.
sasurobert
approved these changes
Nov 7, 2024
axenteoctavian
approved these changes
Nov 8, 2024
mariusmihaic
merged commit deaafbd
into
feat/sovereign-mainchain-header-sync
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
notifierBootstrapperwhich will start waiting on a go routine to be notified via nodeSyncedChan when the sovereign node is synced. Meanwhile, it will print the current node state in log. When node is fully synced, it will register the incoming header processor to the websocket listener and exit the waiting loop.Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?