Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sovereign] Filter out topics/shard ids to broadcast #6573

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Oct 31, 2024

Reasoning behind the pull request

  • Whenever having ougoing operations with shardID = MainChainShardID, broadcast of data will try to write on a "cross shard" topic with main chain, which is invalid and cause warns.

Proposed changes

  • Filter out/skip broadcasting p2p data to main chain

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic changed the title FIX: Quick and dirty fix broadcast to mainchain [sovereign] Filter out topics/shard ids to broadcast Nov 6, 2024
@mariusmihaic mariusmihaic self-assigned this Nov 6, 2024
@mariusmihaic mariusmihaic marked this pull request as ready for review November 7, 2024 14:53
@mariusmihaic mariusmihaic merged commit e67f280 into feat/chain-go-sdk Nov 11, 2024
4 checks passed
@mariusmihaic mariusmihaic deleted the sovereign-fix-broadcast-mainchain branch November 11, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants