-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sovereign] Add config option to disable notifier #6578
Merged
mariusmihaic
merged 5 commits into
feat/sovereign-mainchain-header-sync
from
MX-15961-sov-node-trust-mode
Nov 8, 2024
Merged
[sovereign] Add config option to disable notifier #6578
mariusmihaic
merged 5 commits into
feat/sovereign-mainchain-header-sync
from
MX-15961-sov-node-trust-mode
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusmihaic
changed the title
FEAT: Trust mode: createNotifierWSReceiverServicesIfNeeded
[sovereign] FEAT: Trust mode: createNotifierWSReceiverServicesIfNeeded
Nov 1, 2024
mariusmihaic
changed the title
[sovereign] FEAT: Trust mode: createNotifierWSReceiverServicesIfNeeded
[sovereign] Add config option to disable notifier
Nov 4, 2024
axenteoctavian
previously approved these changes
Nov 5, 2024
sasurobert
previously approved these changes
Nov 6, 2024
# Running an additional main chain light node as a notifier requires extra hardware resources. | ||
# When disabled, the node will rely on and trust incoming headers from the main chain proposed by other leaders. | ||
# Disabling this flag can be useful in scenarios where additional validation infrastructure isn't necessary, | ||
# such as for a CEX observer setup that only requires balance checks on various addresses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove line 52.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remved the line
…ov-node-trust-mode
Base automatically changed from
MX-15963-disable-notifier-until-synced
to
feat/sovereign-mainchain-header-sync
November 8, 2024 10:15
mariusmihaic
dismissed stale reviews from sasurobert and axenteoctavian
November 8, 2024 10:15
The base branch was changed.
…-node-trust-mode # Conflicts: # cmd/sovereignnode/sovereignNodeRunner.go
axenteoctavian
approved these changes
Nov 8, 2024
sasurobert
approved these changes
Nov 8, 2024
mariusmihaic
merged commit Nov 8, 2024
536725b
into
feat/sovereign-mainchain-header-sync
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?