Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sovereign] Add config option to disable notifier #6578

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Nov 1, 2024

Reasoning behind the pull request

  • Add config option to disable notifier

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic self-assigned this Nov 1, 2024
@mariusmihaic mariusmihaic changed the title FEAT: Trust mode: createNotifierWSReceiverServicesIfNeeded [sovereign] FEAT: Trust mode: createNotifierWSReceiverServicesIfNeeded Nov 1, 2024
@mariusmihaic mariusmihaic marked this pull request as ready for review November 4, 2024 15:31
@mariusmihaic mariusmihaic changed the title [sovereign] FEAT: Trust mode: createNotifierWSReceiverServicesIfNeeded [sovereign] Add config option to disable notifier Nov 4, 2024
axenteoctavian
axenteoctavian previously approved these changes Nov 5, 2024
@sasurobert sasurobert self-requested a review November 6, 2024 09:17
sasurobert
sasurobert previously approved these changes Nov 6, 2024
# Running an additional main chain light node as a notifier requires extra hardware resources.
# When disabled, the node will rely on and trust incoming headers from the main chain proposed by other leaders.
# Disabling this flag can be useful in scenarios where additional validation infrastructure isn't necessary,
# such as for a CEX observer setup that only requires balance checks on various addresses.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove line 52.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remved the line

Base automatically changed from MX-15963-disable-notifier-until-synced to feat/sovereign-mainchain-header-sync November 8, 2024 10:15
@mariusmihaic mariusmihaic dismissed stale reviews from sasurobert and axenteoctavian November 8, 2024 10:15

The base branch was changed.

…-node-trust-mode

# Conflicts:
#	cmd/sovereignnode/sovereignNodeRunner.go
@mariusmihaic mariusmihaic merged commit 536725b into feat/sovereign-mainchain-header-sync Nov 8, 2024
4 checks passed
@mariusmihaic mariusmihaic deleted the MX-15961-sov-node-trust-mode branch November 8, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants