[sovereign] Do not request incoming headers upon receiving #6585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
previously approved these changes
Nov 6, 2024
axenteoctavian
previously approved these changes
Nov 6, 2024
| ) | ||
|
|
||
| // GetCurrentSovereignHeader returns current sovereign chain block handler from blockchain hook | ||
| func GetCurrentSovereignHeader(nodeHandler process.NodeHandler) data.SovereignChainHeaderHandler { | ||
| return nodeHandler.GetChainHandler().GetCurrentBlockHeader().(data.SovereignChainHeaderHandler) | ||
| } | ||
|
|
||
| // CreateSovereignRunTypeComponents will create sovereign run type components | ||
| func CreateSovereignRunTypeComponents(args runType.ArgsRunTypeComponents, sovereignExtraConfig config.SovereignConfig) (factory.RunTypeComponentsHolder, error) { |
There was a problem hiding this comment.
The cleanest solution would be to move this function somewhere in /sovereignnode/runtype and use it in both chainSimualtor and sovereignNodeRunner
There was a problem hiding this comment.
Not quite same usage, just verified.
Will leave it as it is
Base automatically changed from
MX-15961-sov-node-trust-mode
to
feat/sovereign-mainchain-header-sync
November 8, 2024 10:36
mariusmihaic
dismissed stale reviews from sasurobert and axenteoctavian
The base branch was changed.
…-request-incoming-header
axenteoctavian
approved these changes
Nov 8, 2024
sasurobert
approved these changes
Nov 8, 2024
mariusmihaic
merged commit a9dcce7
into
feat/sovereign-mainchain-header-sync
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
X+2to be added before one with nonceX+1.doJobOnReceivedCrossNotarizedHeaderreceives a new main chain header, it notifies all relevant handlers viacrossBlockNotifier, which then callsComputeLongestChain. If a header with nonce X+2 is processed first, unnecessary network requests are made to receive headers with nonce X+1.Proposed changes
crossBlockNotifier,we return earlyTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?