Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sovereign bridge contracts wasm update and fixes #6598

Merged

Conversation

axenteoctavian
Copy link
Contributor

@axenteoctavian axenteoctavian commented Nov 12, 2024

Reasoning behind the pull request

  • update bridge contracts wasm

Proposed changes

  • update wasm file and deploy arguments update

Testing procedure

  • sovereign chain simulator tests passed

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@axenteoctavian axenteoctavian self-assigned this Nov 12, 2024
sasurobert
sasurobert previously approved these changes Nov 12, 2024
Base automatically changed from merge-esdt-prefix-into-sovereign-12-nov to feat/chain-go-sdk November 13, 2024 13:40
@axenteoctavian axenteoctavian dismissed sasurobert’s stale review November 13, 2024 13:40

The base branch was changed.

esdtSafeArgs := "@01" + // is_sovereign_chain
"@" + // min_valid_signers
"@" + hex.EncodeToString(wallet.Bytes) // initiator_address
esdtSafeArgs := "@01" // is_sovereign_chain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is or id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means true

@axenteoctavian axenteoctavian merged commit ab8d698 into feat/chain-go-sdk Nov 13, 2024
4 checks passed
@axenteoctavian axenteoctavian deleted the MX-16051-sov-bridge-contracts-update branch November 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants