Dune mock api service #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/dune-simulator/src/endpoints/dune-simulator/dune-simulator.controller.ts
Outdated
Show resolved
Hide resolved
bogdan-rosianu
approved these changes
Sep 4, 2024
… working for charts with many points)
…ndpoint that returns html document with the chart
| public async hatomWebhook(eventsLog: EventLog[], borrowedToken: string): Promise<void> { | ||
|
|
||
| for (const eventLog of eventsLog) { | ||
| const borrowEventInHex = '626f72726f775f6576656e74'; |
There was a problem hiding this comment.
you could have defined the const as regular string and decode the first topic. easier to see what we're looking for
There was a problem hiding this comment.
Wouldn't this be costly? Maybe we can add a comment with the event in string format @bogdan-rosianu
bogdan-rosianu
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.